New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use destroy instead of unlock in CleanupLocksJob #688

Open

papes1ns wants to merge 2 commits into main from fix-cleanup-locks-job

Collaborator

papes1ns commented Oct 4, 2023

Fixes issue where locks don't get destroyed by the CleanupLocksJob.

Using Lockable#unlock fails if associated model is invalid.
Using Lock#destroy skirts that validation

papes1ns added 2 commits

October 4, 2023 16:04


          use destroy in CleanupLocksJob to delete locks to avoid validation er…

e12875f

…rors


          fix tests

0738ce8

papes1ns assigned waisaed and afichter-um

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet